Eric the Coder
Region: IT
Tuesday 30 May 2023 16:51:32 GMT
66393
1602
57
161
Music
Download
Comments
AranyGyaluska :
let's see how they would react to a "???" comment 😈
2023-05-31 18:18:51
272
enbyengy :
"one time a junior pointed out my mistakes so I fired him" said no senior+ dev ever. always give feedback.
2023-05-30 20:51:56
17
Oliver :
As a senior dev I am more than happy with people commenting instead of ignoring the PR
2023-05-31 20:32:45
59
:
it's a feeling, nothing i can actually articulate. i know this is the wrong way to do this, but i can't exactly tell why... also... idk
2023-05-30 18:01:51
37
. :
At this point, I just comment on their typos and formatting errors
2023-05-30 20:11:08
30
M :
Slack: “I’m interested in how you arrived at that approach, would you have 5 minutes to walk me through it?”
2023-06-01 01:55:00
23
codewithvincent :
just do it
2023-05-30 17:02:26
38
Dr. Dvo :
Pls do it, we want to hear juniors opinions and discuss
2023-05-31 20:46:09
15
elo :
Just phrase it differently. Rather than starting with "I don't think", start with "I think.." and make it a suggestion rather than a criticism.
2023-06-01 00:48:43
7
Hamma Azarok :
don't be afraid, do it.😂
2023-05-31 21:38:06
1
sopa de peixe :
personally I would "?"
2023-06-01 02:36:29
2
Elis Byberi :
"Why we don't do x, instrad of y?" Is the right way to suggest, if you are not a domain expert. They will be more than happy to respond to you.
2023-06-01 09:44:58
1
Dmitry Omelchenko :
please make sure that you offer a solution and not just criticize, then even if you are wrong you will make a good impression
2023-06-01 00:26:21
3
Fardarterfu :
Don’t say it’s the wrong approach. Suggest an alternative and ask if they think it would work
2023-06-02 20:42:22
2
🎃 :
“What do you think about this approach? Could we improve on my solution? Thanks!”
2023-05-31 21:48:57
3
infalodon :
No fear man, if he takes it wrong, you’re probably better than him
2023-06-01 03:27:20
1
Pat :
You can start with , “have you consider…” or “ I am curious what happens if..”, depend of the contex, try to be positive instead..
2023-06-01 12:31:50
3
Manivela :
do it. but be ready to fix it yourself as well 😅
2023-05-31 21:42:27
1
near :
Why and what's the alternative you're considering? Most things are about tradeoffs. Share your thoughts. Both people have room to learn
2023-06-01 12:14:26
1
Joshua Hendrix :
😂 I hear it’s hard the other way around too
2023-05-30 16:55:38
2
MM :
I m stuck trying to upload my projects on GitHub.. 🥹
2023-06-03 13:46:13
0
pygar :
what you do is call or IM them. "can you explain this bit I don't get please"
2023-06-05 22:33:10
0
Puisín :
Yep! Definitely a lot of that
2023-06-02 15:24:05
0
Mikapo :
As mid dev this still feels so accurate 😂 I think only seniors can actually review another senior 🤧
2023-06-02 14:09:08
0
Alex :
Just dont
2023-05-31 19:58:26
0
To see more videos from user @ericthecoder, please go to the Tikwm
homepage.
